Improved Javadoc For Db Interfaces, Added countf Function #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danthe1st
reviewed
Jun 11, 2022
| * @param args The set of arguments to pass to the formatter. | ||
| * @return The count. | ||
| */ | ||
| public static long countf(String queryFormat, Object... args) { |
Member
There was a problem hiding this comment.
What's the purpose of that method? Why not use PreparedStatement for this?
Contributor
Author
There was a problem hiding this comment.
It makes count operations more compact and removes them from the specificity of jdbc.
countf("SELECT COUNT(id) FROM entries WHERE id = %d", 4);versus
count("SELECT COUNT(id) FROM entries WHERE id = ?", s -> s.setLong(1, 4));
Member
There was a problem hiding this comment.
I don't think such a method should be created since it may be used accidentally for user input without reading the documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.